gaborgsomogyi commented on a change in pull request #22138: [SPARK-25151][SS]
Apply Apache Commons Pool to KafkaDataConsumer
URL: https://github.com/apache/spark/pull/22138#discussion_r302986154
##########
File path:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaDataConsumerSuite.scala
##########
@@ -51,20 +49,37 @@ class KafkaDataConsumerSuite extends SharedSQLContext with
PrivateMethodTester {
super.afterAll()
}
+ private var fetchedDataPool: FetchedDataPool = _
+ private var consumerPool: InternalKafkaConsumerPool = _
+
+ override def beforeEach(): Unit = {
+ fetchedDataPool = {
+ val fetchedDataPoolHack =
PrivateMethod[FetchedDataPool]('fetchedDataPool)
Review comment:
Maybe better to call `...Method` than `...Hack`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]