Ngone51 commented on a change in pull request #23677: [SPARK-26755][SCHEDULER]
: Optimize Spark Scheduler to dequeue speculative tasks…
URL: https://github.com/apache/spark/pull/23677#discussion_r303008634
##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##########
@@ -1137,3 +1048,12 @@ private[spark] object TaskSetManager {
// this.
val TASK_SIZE_TO_WARN_KIB = 1000
}
+
+private[scheduler] class PendingTasksByLocality {
+
+ val forExecutor: HashMap[String, ArrayBuffer[Int]] = new HashMap[String,
ArrayBuffer[Int]]
+ val forHost: HashMap[String, ArrayBuffer[Int]] = new HashMap[String,
ArrayBuffer[Int]]
+ val noPrefs: ArrayBuffer[Int] = new ArrayBuffer[Int]
+ val forRack: HashMap[String, ArrayBuffer[Int]] = new HashMap[String,
ArrayBuffer[Int]]
+ val anyPrefs: ArrayBuffer[Int] = new ArrayBuffer[Int]
Review comment:
The declaration seems a little redundant. Maybe, we can remove the explicit
type declaration ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
