rdblue commented on a change in pull request #25104: [SPARK-28341][SQL] refine
the v2 session catalog config
URL: https://github.com/apache/spark/pull/25104#discussion_r303083354
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalogSuite.scala
##########
@@ -62,23 +62,13 @@ class V2SessionCatalogSuite
}
private def newCatalog(): TableCatalog = {
- val newCatalog = new V2SessionCatalog(spark.sessionState)
+ val newCatalog = new V2SessionCatalog(spark.sessionState.catalog,
spark.sessionState.conf)
newCatalog.initialize("test", CaseInsensitiveStringMap.empty())
newCatalog
}
private val testIdent = Identifier.of(Array("db"), "test_table")
- test("Catalogs can load the catalog") {
Review comment:
With your recent changes, I think the session catalog is loaded by name now,
so this test should be restored.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
