HeartSaVioR commented on a change in pull request #25135: [SPARK-28367][SS] Use
new KafkaConsumer.poll API in Kafka connector
URL: https://github.com/apache/spark/pull/25135#discussion_r303155155
##########
File path:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala
##########
@@ -310,6 +309,20 @@ class KafkaTestUtils(withBrokerProps: Map[String, Object]
= Map.empty) extends L
offsets
}
+ private def getPartitions(consumer: KafkaConsumer[String, String]):
JSet[TopicPartition] = {
Review comment:
Duplicated code. Maybe we could put this in utility class or somewhere and
pass timeout as parameter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
