shivsood commented on issue #25146: [SPARK-28152] [SQL] Mapped ShortType to 
SMALLINT and FloatType to REAL for correct read/write of SQLServer Tables using 
JDBC connector
URL: https://github.com/apache/spark/pull/25146#issuecomment-511149909
 
 
   > BTW, @shivsood .
   > Since you are going to contribute more to Apache Spark community, I'll 
give you some comments on the current PR title.
   > 
   > > Fix for SPARK-28152: ShortType and FloatTypes are not mapped correctly 
for read/write of SQLServer Tables
   > 
   >     * We use `[SPARK-28152]` prefix followed by the component tag like 
`[SQL]`.
   > 
   >     * We recommend to use the PR title to describe your approach, not a 
problem. The problem description and the comparison between before and after 
are done in the PR description.
   
   Thanks dongjoon-hyun. I have fixed this. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to