HyukjinKwon commented on a change in pull request #25142: [SPARK-28378][Python]
Remove usage of cgi.escape
URL: https://github.com/apache/spark/pull/25142#discussion_r303228181
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -375,7 +375,12 @@ def _repr_html_(self):
by 'spark.sql.repl.eagerEval.enabled', this only called by REPL you are
using support eager evaluation with HTML.
"""
- import cgi
+ try:
Review comment:
I believe either way is fine per
https://docs.python.org/3/howto/pyporting.html#use-feature-detection-instead-of-version-detection
but yea, let's use pre-defined condition then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
