MaxGekk commented on issue #25153: [SPARK-28389][SQL] Use Java 8 API in add_months URL: https://github.com/apache/spark/pull/25153#issuecomment-511233395 The latest build failed on `CollectionExpressionsSuite`, in particular on: ``` checkEvaluation(new Sequence( Literal(Date.valueOf("2018-01-31")), Literal(Date.valueOf("2018-04-30")), Literal(CalendarInterval.fromString("interval 1 month"))), Seq( Date.valueOf("2018-01-31"), Date.valueOf("2018-02-28"), Date.valueOf("2018-03-31"), Date.valueOf("2018-04-30"))) ``` because current implementation incrementally adds steps of month and micros to previous value. So, such implementation produces: ``` Seq( Date.valueOf("2018-01-31"), Date.valueOf("2018-02-28"), Date.valueOf("2018-03-28"), Date.valueOf("2018-04-28")) ``` I am going to change this in `TemporalSequenceImpl` to `arr[i+1] = add_monts(start, i * stepMonth, i * stepMicros, timeZone)`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
