HyukjinKwon commented on a change in pull request #25130: 
[SPARK-28359][test-maven][SQL][PYTHON][TESTS] Make integrated UDF tests robust 
by making UDFs (virtually) no-op
URL: https://github.com/apache/spark/pull/25130#discussion_r303277726
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala
 ##########
 @@ -980,7 +980,7 @@ class JoinSuite extends QueryTest with SharedSQLContext {
 
     val left = Seq((1, 2), (2, 3)).toDF("a", "b")
     val right = Seq((1, 2), (3, 4)).toDF("c", "d")
-    val df = left.join(right, pythonTestUDF($"a") === pythonTestUDF($"c"))
 
 Review comment:
   Yea .. I would like to eventually support that case in the near future ... 
Problem is that we need to get the type of input column to set it back when it 
casts back to the input type but `$"col"` gives unresolved attribute. So 
apparently cannot peek the input type.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to