HyukjinKwon commented on a change in pull request #25133: [SPARK-28365][ML]
Fallback locale to en_US in StopWordsRemover if system default locale isn't in
available locales in JVM
URL: https://github.com/apache/spark/pull/25133#discussion_r303278713
##########
File path:
mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala
##########
@@ -89,7 +89,8 @@ class StopWordsRemover @Since("1.5.0") (@Since("1.5.0")
override val uid: String
/**
* Locale of the input for case insensitive matching. Ignored when
[[caseSensitive]]
* is true.
- * Default: Locale.getDefault.toString
+ * Default: the string of default locale (`Locale.getDefault`), or
`Locale.US` if default locale
+ * isn't in available locales in JVM.
Review comment:
not a biggie but I usually avoid abbreviation in the doc `isn't` -> `is not`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
