wangyum commented on a change in pull request #24931: [SPARK-28129][SQL][TEST]
Port float8.sql
URL: https://github.com/apache/spark/pull/24931#discussion_r303353368
##########
File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/float8.sql
##########
@@ -180,16 +180,16 @@ SELECT '' AS bad, f.f1 * '1e200' from UPDATED_FLOAT8_TBL
f;
SELECT '' AS five, * FROM UPDATED_FLOAT8_TBL;
--- [SPARK-28133] Missing hyperbolic functions
-- hyperbolic functions
-- we run these with extra_float_digits = 0 too, since different platforms
-- tend to produce results that vary in the last place.
--- SELECT sinh(float8 '1');
--- SELECT cosh(float8 '1');
--- SELECT tanh(float8 '1');
--- SELECT asinh(float8 '1');
--- SELECT acosh(float8 '2');
--- SELECT atanh(float8 '0.5');
+SELECT sinh(double('1'));
+SELECT cosh(double('1'));
+SELECT tanh(double('1'));
+SELECT asinh(double('1'));
+SELECT acosh(double('2'));
+SELECT atanh(double('0.5'));
+-- [SPARK-27768] Infinity, -Infinity, NaN should be recognized in a case
insensitive manner
-- test Inf/NaN cases for hyperbolic functions
-- SELECT sinh(float8 'infinity');
Review comment:
Do we need to rewrite `sinh(float8 'infinity')` to
`sinh(double('Infinity'))`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
