yeshengm commented on a change in pull request #25145: [SPARK-28375][SQL] Make
PullupCorrelatedPredicates idempotent
URL: https://github.com/apache/spark/pull/25145#discussion_r303562517
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
##########
@@ -246,10 +246,10 @@ object PullupCorrelatedPredicates extends
Rule[LogicalPlan] with PredicateHelper
// In case of a collision, change the subquery plan's output to use
// different attribute by creating alias(s).
val baseConditions = predicateMap.values.flatten.toSeq
- val (newPlan, newCond) = if (outer.nonEmpty) {
+ if (outer.nonEmpty) {
Review comment:
Is this change necessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
