dongjoon-hyun commented on a change in pull request #25147: [SPARK-28333][SQL]
NULLS FIRST for DESC and NULLS LAST for ASC
URL: https://github.com/apache/spark/pull/25147#discussion_r303603005
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
##########
@@ -36,12 +36,12 @@ abstract sealed class NullOrdering {
case object Ascending extends SortDirection {
override def sql: String = "ASC"
- override def defaultNullOrdering: NullOrdering = NullsFirst
+ override def defaultNullOrdering: NullOrdering = NullsLast
}
case object Descending extends SortDirection {
override def sql: String = "DESC"
- override def defaultNullOrdering: NullOrdering = NullsLast
+ override def defaultNullOrdering: NullOrdering = NullsFirst
Review comment:
+1 for @HyukjinKwon 's comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
