squito commented on a change in pull request #23677: [SPARK-26755][SCHEDULER] :
Optimize Spark Scheduler to dequeue speculative tasks…
URL: https://github.com/apache/spark/pull/23677#discussion_r303599766
##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##########
@@ -234,63 +228,41 @@ private[spark] class TaskSetManager(
/** Add a task to all the pending-task lists that it should be on. */
private[spark] def addPendingTask(
index: Int,
- resolveRacks: Boolean = true): Unit = {
+ resolveRacks: Boolean = true,
+ speculative: Boolean = false): Unit = {
Review comment:
following on comment above, this should be called "speculatable"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
