Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/3960#discussion_r22918651
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -310,4 +311,17 @@ private[sql] abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
case _ => Nil
}
}
+
+ object DDLStrategy extends Strategy {
--- End diff --
@yhuai,i write a draft version for this, can you have a
look(https://github.com/scwf/spark/compare/apache:master...scwf:createDataSourceTable?expand=1)
why we put ``` case r: RunnableCommand => ExecutedCommand(r)``` in
BasicOperators is because we no need make a new strategy for only one rule.
And after we refactor command implementation in spark sql, we should make
the newly added command follow ```RunnableCommand``` if possible then we can
avoid adding new strategy for newly added command.
/cc @marmbrus
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
