dongjoon-hyun commented on a change in pull request #24903: [SPARK-28084][SQL]
Resolving the partition column name based on the resolver in sql load command
URL: https://github.com/apache/spark/pull/24903#discussion_r303726406
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
##########
@@ -290,6 +291,13 @@ class HiveCommandSuite extends QueryTest with
SQLTestUtils with TestHiveSingleto
checkAnswer(
sql("SELECT employeeID, employeeName FROM part_table WHERE c = '2' AND
d = '1'"),
sql("SELECT * FROM non_part_table").collect())
+
+ // check for case insensitive of partition columns while querying.
+ withSQLConf(SQLConf.CASE_SENSITIVE.key -> "false") {
+ checkAnswer(
+ sql("SELECT employeeID, employeeName FROM part_table WHERE C = '2'
AND D = '1'"),
+ sql("SELECT * FROM non_part_table").collect())
+ }
Review comment:
This UT seems to succeed without your code. Please provide a valid UT to
validate your contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
