maropu commented on a change in pull request #25001: [SPARK-28083][SQL] Support 
LIKE ... ESCAPE syntax
URL: https://github.com/apache/spark/pull/25001#discussion_r303877847
 
 

 ##########
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
 ##########
 @@ -83,33 +83,39 @@ abstract class StringRegexExpression extends 
BinaryExpression
           % matches zero or more characters in the input (similar to .* in 
posix regular
           expressions)
 
-          The escape character is '\'. If an escape character precedes a 
special symbol or another
-          escape character, the following character is matched literally. It 
is invalid to escape
-          any other character.
-
           Since Spark 2.0, string literals are unescaped in our SQL parser. 
For example, in order
           to match "\abc", the pattern should be "\\abc".
 
           When SQL config 'spark.sql.parser.escapedStringLiterals' is enabled, 
it fallbacks
           to Spark 1.6 behavior regarding string literal parsing. For example, 
if the config is
           enabled, the pattern to match "\abc" should be "\abc".
+      * escape - a optional string. The default escape character is the '\' 
but a different one
+          can be selected by using the ESCAPE clause. If an escape character 
precedes a special
+          symbol or another escape character, the following character is 
matched literally. It is
+          invalid to escape any other character.
 
 Review comment:
   How about this?
   ```
         * escape - an optional string. The default escape character is the '\' 
. If an escape character
               precedes a special symbol or another escape character, the 
following character is matched
               literally. It is invalid to escape any other character.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to