tgravescs commented on a change in pull request #25047: [WIP][SPARK-27371][CORE] Support GPU-aware resources scheduling in Standalone URL: https://github.com/apache/spark/pull/25047#discussion_r303952636
########## File path: core/src/main/scala/org/apache/spark/deploy/master/DriverInfo.scala ########## @@ -34,6 +35,9 @@ private[deploy] class DriverInfo( @transient var exception: Option[Exception] = None /* Most recent worker assigned to this driver */ @transient var worker: Option[WorkerInfo] = None + // resources(e.f. gpu/fpga) allocated to this driver + // map from resource name to ResourceInformation + private var _resources: Map[String, ResourceInformation] = _ Review comment: this seems a bit odd to be mutable, looks like this one might be harder to pass into constructor though? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
