tgravescs commented on a change in pull request #25047: 
[WIP][SPARK-27371][CORE] Support GPU-aware resources scheduling in Standalone
URL: https://github.com/apache/spark/pull/25047#discussion_r303931387
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/resource/ResourceUtils.scala
 ##########
 @@ -61,7 +65,19 @@ private[spark] case class ResourceAllocation(id: 
ResourceID, addresses: Seq[Stri
   }
 }
 
+/**
+ * Resource allocation used in Standalone only, which tracks assignments with
+ * worker/driver(client only) pid.
+ */
+private[spark]
+case class StandaloneResourceAllocation(pid: Int, allocations: 
Seq[ResourceAllocation])
+
 private[spark] object ResourceUtils extends Logging {
+  // These directory/files are used to coordinate the resources between
+  // the drivers/workers on the host in Spark Standalone.
+  val SPARK_RESOURCES_DIRECTORY = "spark-resources"
 
 Review comment:
   Its a bit odd this is so close to the config name SPARK_RESOURCES_DIR.   
perhaps call this SPARK_RESOURCES_SUBDIR or something else more unique

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to