dilipbiswal commented on a change in pull request #25164: [SPARK-28375] Prevent
the PullupCorrelatedPredicates optimizer rule from removing predicates if run
multiple times
URL: https://github.com/apache/spark/pull/25164#discussion_r304099586
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
##########
@@ -275,13 +275,16 @@ object PullupCorrelatedPredicates extends
Rule[LogicalPlan] with PredicateHelper
plan transformExpressions {
case ScalarSubquery(sub, children, exprId) if children.nonEmpty =>
val (newPlan, newCond) = pullOutCorrelatedPredicates(sub, outerPlans)
- ScalarSubquery(newPlan, newCond, exprId)
+ val conds = newCond ++ children.filter(_.isInstanceOf[Predicate])
Review comment:
@yeshengm Trying to remember...
> From my understanding, this rule PullupCorrelatedPredicates should only
run if the plan contains outer ref.
I am not a 100% sure.. but from what i can see and remember, the reason we
call PullupCorrelatedPredicates without a guard is probably to handle
du-duplication of projected attributes. However, NOW the de-duplication is
handled in other places as well. So we probably need to take another look at it
and clean-up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
