gczsjdy commented on a change in pull request #25007:
[SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API
URL: https://github.com/apache/spark/pull/25007#discussion_r304190988
##########
File path:
core/src/main/scala/org/apache/spark/shuffle/sort/SortShuffleManager.scala
##########
@@ -79,6 +83,8 @@ private[spark] class SortShuffleManager(conf: SparkConf)
extends ShuffleManager
*/
private[this] val numMapsForShuffle = new ConcurrentHashMap[Int, Int]()
+ private lazy val shuffleExecutorComponents =
loadShuffleExecutorComponents(conf)
+
override val shuffleBlockResolver = new IndexShuffleBlockResolver(conf)
Review comment:
`SortShuffleManager` is for all ShuffleIO implementations after your series,
but `IndexShffleBlockResolver` is only for the default local
implementation(vanilla Spark's), so...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
