beliefer commented on a change in pull request #25074: [SPARK-27924][SQL]
Support ANSI SQL Boolean-Predicate syntax
URL: https://github.com/apache/spark/pull/25074#discussion_r304214964
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -1223,6 +1223,12 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
case c: CreateNamedStruct => c.valExprs
case other => Seq(other)
}
+ // Check the argument of boolean test is valid.
+ def checkBooleanTestArgs(e: Expression): Unit = e.dataType match {
Review comment:
private not allowd here. It will makes a error:
```
ESC[0m[ESC[31merrorESC[0m]
ESC[0m/home/xitong/code/gengjiaan/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:1227:
illegal start of statement (no modifiers allowed here)ESC[0m
ESC[0m[ESC[31merrorESC[0m] ESC[0m private def checkBooleanTestArgs(e:
Expression): Unit = e.dataType match {ESC[0m
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
