Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/4016#discussion_r22946654
--- Diff: core/src/test/scala/org/apache/spark/util/EventLoopSuite.scala ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.util
+
+import java.util.concurrent.CountDownLatch
+
+import scala.collection.mutable
+import scala.concurrent.duration._
+import scala.language.postfixOps
+
+import org.scalatest.concurrent.Eventually._
+import org.scalatest.concurrent.Timeouts
+import org.scalatest.FunSuite
+
+class EventLoopSuite extends FunSuite with Timeouts {
+
+ test("EventLoop") {
+ val buffer = new mutable.ArrayBuffer[Int] with
mutable.SynchronizedBuffer[Int]
+ val eventLoop = new EventLoop[Int]("test") {
+
+ override def onReceive(event: Int): Unit = {
+ buffer += event
+ }
+
+ override def onError(e: Throwable): Unit = {}
+ }
+ eventLoop.start()
+ (1 to 100).foreach(eventLoop.post)
+ eventually(timeout(5 seconds), interval(200 millis)) {
+ assert((1 to 100) === buffer.toSeq)
+ }
+ eventLoop.stop()
+ }
+
+ test("EventLoop: start and stop") {
+ val eventLoop = new EventLoop[Int]("test") {
+
+ override def onReceive(event: Int): Unit = {}
+
+ override def onError(e: Throwable): Unit = {}
+ }
+ assert(false === eventLoop.isActive)
+ eventLoop.start()
+ assert(true === eventLoop.isActive)
+ eventLoop.stop()
+ assert(false === eventLoop.isActive)
+ }
+
+ test("EventLoop: onError") {
+ val e = new RuntimeException("Oops")
+ @volatile var receivedError: Throwable = null
+ val eventLoop = new EventLoop[Int]("test") {
+
+ override def onReceive(event: Int): Unit = {
+ throw e
+ }
+
+ override def onError(e: Throwable): Unit = {
+ receivedError = e
+ }
+ }
+ eventLoop.start()
+ eventLoop.post(1)
+ eventually(timeout(5 seconds), interval(200 millis)) {
+ assert(e === receivedError)
+ }
+ eventLoop.stop()
+ }
+
+ test("EventLoop: error thrown from onError should not crash the event
thread") {
+ val e = new RuntimeException("Oops")
+ @volatile var receivedError: Throwable = null
+ val eventLoop = new EventLoop[Int]("test") {
+
+ override def onReceive(event: Int): Unit = {
+ throw e
+ }
+
+ override def onError(e: Throwable): Unit = {
+ receivedError = e
+ throw new RuntimeException("Oops")
+ }
+ }
+ eventLoop.start()
+ eventLoop.post(1)
+ eventually(timeout(5 seconds), interval(200 millis)) {
+ assert(e === receivedError)
+ assert(eventLoop.isActive)
+ }
+ eventLoop.stop()
+ }
+
+ test("EventLoop: calling stop multiple times should only call onStop
once") {
+ var onStopTimes = 0
+ val eventLoop = new EventLoop[Int]("test") {
+
+ override def onReceive(event: Int): Unit = {
+ }
+
+ override def onError(e: Throwable): Unit = {
+ }
+
+ override def onStop(): Unit = {
+ onStopTimes += 1
+ }
+ }
+
+ eventLoop.start()
+
+ eventLoop.stop()
+ eventLoop.stop()
+ eventLoop.stop()
+
+ assert(1 === onStopTimes)
+ }
+
+ test("EventLoop: post event in multiple threads") {
+ @volatile var receivedEventsCount = 0
+ val eventLoop = new EventLoop[Int]("test") {
+
+ override def onReceive(event: Int): Unit = {
+ receivedEventsCount += 1
--- End diff --
Is += safe on a volatile int? I wouldn't think it's actually rewritten as a
compareAndSwap loop.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
