srowen commented on issue #25186: [SPARK-28433][SQL]Special scala test case for aarch64 URL: https://github.com/apache/spark/pull/25186#issuecomment-512815515 I think this change is narrowly fine. I'm actually not sure why we test the result of this JDK method directly; it's not a Spark method. @cloud-fan I think you added this? I'm wondering if there are other usages of floatToRawIntBits, and I see only one other in QueryTest. There it's just comparing floats as bits to distinguish 0 and -0, and the varying representation of NaN probably doesn't matter. But by the same token, I think that code in QueryTest should use floatToIntBits to canonicalize NaN? maybe even have a better test to exercise NaN. So: I think my suggestion is to delete these assertions instead.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
