kiszk commented on a change in pull request #25186: [SPARK-28433][SQL]Special
scala test case for aarch64
URL: https://github.com/apache/spark/pull/25186#discussion_r304990702
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala
##########
@@ -728,9 +728,15 @@ class DataFrameAggregateSuite extends QueryTest with
SharedSQLContext {
import java.lang.Float.floatToRawIntBits
import java.lang.Double.doubleToRawLongBits
- // 0.0/0.0 and NaN are different values.
- assert(floatToRawIntBits(0.0f/0.0f) != floatToRawIntBits(Float.NaN))
Review comment:
I have one question. Does this difference between two architectures cause
the difference of results in a Spark program? Could you please add such a test
case?
If this difference does not cause any difference of results, we do not need
to take care of this difference. In other words, I think that we do not need to
add this test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
