mccheah commented on a change in pull request #25007:
[SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API
URL: https://github.com/apache/spark/pull/25007#discussion_r305106299
##########
File path: core/src/test/scala/org/apache/spark/ShuffleSuite.scala
##########
@@ -383,13 +383,19 @@ abstract class ShuffleSuite extends SparkFunSuite with
Matchers with LocalSparkC
// simultaneously, and everything is still OK
def writeAndClose(
- writer: ShuffleWriter[Int, Int])(
+ writer: ShuffleWriter[Int, Int],
+ taskContext: TaskContext)(
iter: Iterator[(Int, Int)]): Option[MapStatus] = {
- val files = writer.write(iter)
- writer.stop(true)
+ TaskContext.setTaskContext(taskContext)
Review comment:
`TaskContext` should only be used for internal implementations, such as the
local write implementation, or suppose if Spark provided libraries for
async-write implementations. Basically, I'd only expect the `TaskContext` to be
used by spark-provided implementations. Otherwise, metrics should be tracked by
the implementation's specific metrics systems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
