Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4028#discussion_r22960975
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
    @@ -121,27 +125,47 @@ private[ui] class AllJobsPage(parent: JobsTab) 
extends WebUIPage("") {
                   <strong>Scheduling Mode: </strong>
                   
{listener.schedulingMode.map(_.toString).getOrElse("Unknown")}
                 </li>
    -            <li>
    -              <a href="#active"><strong>Active Jobs:</strong></a>
    -              {activeJobs.size}
    -            </li>
    -            <li>
    -              <a href="#completed"><strong>Completed Jobs:</strong></a>
    -              {completedJobs.size}
    -            </li>
    -            <li>
    -              <a href="#failed"><strong>Failed Jobs:</strong></a>
    -              {failedJobs.size}
    -            </li>
    +            {
    +              if (shouldShowActiveJobs) {
    +                <li>
    +                  <a href="#active"><strong>Active Jobs:</strong></a>
    +                  {activeJobs.size}
    +                </li>
    +              }
    +            }
    +            {
    +              if (shouldShowCompletedJobs) {
    +                <li>
    +                  <a href="#completed"><strong>Completed Jobs:</strong></a>
    +                  {completedJobs.size}
    +                </li>
    +              }
    +            }
    +            {
    +              if (shouldShowFailedJobs) {
    +                <li>
    +                  <a href="#failed"><strong>Failed Jobs:</strong></a>
    +                  {failedJobs.size}
    +                </li>
    +              }
    +            }
               </ul>
             </div>
     
    -      val content = summary ++
    -        <h4 id="active">Active Jobs ({activeJobs.size})</h4> ++ 
activeJobsTable ++
    -        <h4 id="completed">Completed Jobs ({completedJobs.size})</h4> ++ 
completedJobsTable ++
    -        <h4 id ="failed">Failed Jobs ({failedJobs.size})</h4> ++ 
failedJobsTable
    -
    -      val helpText = """A job is triggered by a action, like "count()" or 
"saveAsTextFile()".""" +
    +      var content = summary
    +      if (shouldShowActiveJobs) {
    +        content ++= <h4 id="active">Active Jobs ({activeJobs.size})</h4> ++
    +          activeJobsTable
    +      }
    +      if (shouldShowCompletedJobs) {
    +        content ++= <h4 id="completed">Completed Jobs 
({completedJobs.size})</h4> ++
    +          completedJobsTable
    +      }
    +      if (shouldShowFailedJobs) {
    +        content ++= <h4 id ="failed">Failed Jobs ({failedJobs.size})</h4> 
++
    +          failedJobsTable
    +      }
    +      val helpText = """A job is triggered by an action, like "count()" or 
"saveAsTextFile()".""" +
    --- End diff --
    
    Thanks for catching and fixing this typo.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to