maropu commented on a change in pull request #25071: [SPARK-28292][SQL] Enable
inject user-defined Hint
URL: https://github.com/apache/spark/pull/25071#discussion_r305177692
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -151,9 +156,10 @@ class Analyzer(
lazy val batches: Seq[Batch] = Seq(
Batch("Hints", fixedPoint,
- new ResolveHints.ResolveJoinStrategyHints(conf),
- ResolveHints.ResolveCoalesceHints,
- new ResolveHints.RemoveAllHints(conf)),
+ new ResolveHints.ResolveJoinStrategyHints(conf) +:
+ ResolveHints.ResolveCoalesceHints +:
+ extendedResolutionHints :+
Review comment:
cc: @maryannxue , too. (I think this kind of extensions is basically
bug-prone and we always need a better design...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
