maropu commented on a change in pull request #25186: [SPARK-28433][SQL]Special
scala test case for aarch64
URL: https://github.com/apache/spark/pull/25186#discussion_r305202389
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala
##########
@@ -728,9 +728,15 @@ class DataFrameAggregateSuite extends QueryTest with
SharedSQLContext {
import java.lang.Float.floatToRawIntBits
import java.lang.Double.doubleToRawLongBits
- // 0.0/0.0 and NaN are different values.
- assert(floatToRawIntBits(0.0f/0.0f) != floatToRawIntBits(Float.NaN))
- assert(doubleToRawLongBits(0.0/0.0) != doubleToRawLongBits(Double.NaN))
+ if (System.getProperty("os.arch").contains("aarch64")) {
Review comment:
Just a question; the existing tests call `System.setProperty("os.arch",
"xxx")`, so this affects this check? e.g.,
https://github.com/apache/spark/blob/master/core/src/test/scala/org/apache/spark/util/SizeEstimatorSuite.scala#L195
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
