HyukjinKwon commented on a change in pull request #25196: [SPARK-28279][SQL][PYTHON][TESTS] Convert and port 'group-analytics.sql' into UDF test base URL: https://github.com/apache/spark/pull/25196#discussion_r305322370
########## File path: sql/core/src/test/resources/sql-tests/inputs/udf/udf-group-analytics.sql ########## @@ -0,0 +1,63 @@ +-- This test file was converted from group-analytics.sql. +CREATE OR REPLACE TEMPORARY VIEW testData AS SELECT * FROM VALUES Review comment: @skonto, sorry last nit. Can you add a comment, with the JIRA you're going to file at https://github.com/apache/spark/pull/25098#discussion_r305313127 ? e.g. ``` -- TODO: UDF should be inserted and tested at GROUP BY clause after SPARK-XXXXX ``` It's kind of sad that we can't test `GROUP BY` with UDF at grouping specific test cases ... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
