[GitHub] [spark] sujith71955 edited a comment on issue #24903: [SPARK-28084][SQL] Resolving the partition column name based on the resolver in sql load command

Fri, 19 Jul 2019 08:21:31 -0700 

sujith71955 edited a comment on issue #24903: [SPARK-28084][SQL] Resolving the 
partition column name based on the resolver in sql load command 
URL: https://github.com/apache/spark/pull/24903#issuecomment-513241936
 
 
   > @sujith71955 .
   > The same code path exists in both `loadPartition` and 
`loadDynamicPartitions`. Could you make a test case for both code branch? For 
`loadDynamicPartition`, you may need to use `INSERT INTO` statement.
   
   INSERT INTO command is working fine, below logic will normalize the 
paritionspec by updating the key
   from metadata.
   Refer : normalizePartitionSpec() in PartitioningUtils
   
   @dongjoon-hyun  shall we update our logic to use this API?
   Anyways i added a UT  also to verify the Insert into command case. Thanks.
   
   
![image](https://user-images.githubusercontent.com/12999161/61525928-06789600-aa37-11e9-9bed-dc0d51e9fcec.png
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to