pgandhi999 commented on a change in pull request #23677:
[SPARK-26755][SCHEDULER] : Optimize Spark Scheduler to dequeue speculative
tasks…
URL: https://github.com/apache/spark/pull/23677#discussion_r305486539
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala
##########
@@ -1166,7 +1168,7 @@ class TaskSetManagerSuite extends SparkFunSuite with
LocalSparkContext with Logg
// Because the SchedulerBackend was a mock, the 2nd copy of the task won't
actually be
// killed, so the FakeTaskScheduler is only told about the successful
completion
// of the speculated task.
- assert(sched.endedTasks(3) === Success)
+ assert(sched.endedTasks(4) === Success)
Review comment:
We have changed the previous HashSet to ArrayBuffer, so now the dequeue
logic remains same but order of tasks stored in the ArrayBuffer will be
different and as the dequeuing of tasks picks up the first possible task that
satisfies all conditions, a different task will be dequeued now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
