squito commented on a change in pull request #25007:
[SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API
URL: https://github.com/apache/spark/pull/25007#discussion_r305385624
##########
File path:
core/src/test/scala/org/apache/spark/shuffle/sort/BypassMergeSortShuffleWriterSuite.scala
##########
@@ -83,14 +83,10 @@ class BypassMergeSortShuffleWriterSuite extends
SparkFunSuite with BeforeAndAfte
null
}.when(blockResolver)
.writeIndexFileAndCommit(anyInt, anyInt, any(classOf[Array[Long]]),
any(classOf[File]))
+
when(blockManager.diskBlockManager).thenReturn(diskBlockManager)
- when(blockManager.getDiskWriter(
- any[BlockId],
- any[File],
- any[SerializerInstance],
- anyInt(),
- any[ShuffleWriteMetrics]
- )).thenAnswer((invocation: InvocationOnMock) => {
+
+ doAnswer((invocation: InvocationOnMock) => {
Review comment:
you changed it to be consistently the way I find more confusing :P
sorry if my original comment was vague.
anyway, not a firm thing, like i said we already use both in the code so
your call
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
