gatorsmile commented on a change in pull request #25111: [SPARK-28346][SQL]
clone the query plan between analyzer, optimizer and planner
URL: https://github.com/apache/spark/pull/25111#discussion_r305516180
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/QueryExecutionSuite.scala
##########
@@ -138,4 +139,27 @@ class QueryExecutionSuite extends SharedSQLContext {
val error = intercept[Error](qe.toString)
assert(error.getMessage.contains("error"))
}
+
+ test("analyzed plan should not change after it's generated") {
Review comment:
The tests still can pass without calling clone() in QueryExecution
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
