rdblue commented on a change in pull request #25206: [SPARK-28265][SQL] Add
renameTable to TableCatalog API
URL: https://github.com/apache/spark/pull/25206#discussion_r305554315
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/catalog/v2/TableCatalog.java
##########
@@ -134,4 +134,23 @@ Table alterTable(
* @return true if a table was deleted, false if no table exists for the
identifier
*/
boolean dropTable(Identifier ident);
+
+ /**
+ * Rename a table in the catalog.
+ * <p>
+ * If the catalog supports views and contains a view for the old identifier
and not a table, this
+ * must throw {@link NoSuchTableException}. Additionally, if the new
identifier is a table
+ * or a view, this must throw {@link TableAlreadyExistsException}.
+ * <p>
+ * Renaming tables is only available within same database in the same
catalog, hence old and new
+ * identifiers must have the same namespace, otherwise this must throw
{@link }
Review comment:
I think this paragraph can be removed, and the link is also broken.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
