dongjoon-hyun commented on a change in pull request #25208: [SPARK-28455][core]
Avoid overflow when calculating executor timeout time.
URL: https://github.com/apache/spark/pull/25208#discussion_r305567385
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/dynalloc/ExecutorMonitor.scala
##########
@@ -188,7 +188,12 @@ private[spark] class ExecutorMonitor(
exec.updateActiveShuffles(activeShuffleIds)
if (exec.hasActiveShuffle) {
needTimeoutUpdate = true
- activatedExecs += id
+ // Don't collect too many ids or the debug message becomes not
very useful.
+ if (activatedExecs.size < 10) {
+ activatedExecs += id
+ } else if (activatedExecs.size == 10) {
+ activatedExecs += "..."
+ }
Review comment:
Shall we wrap this with `if (log.isDebugEnabled) { ... }`, too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
