dongjoon-hyun commented on a change in pull request #25074: [SPARK-27924][SQL]
Support ANSI SQL Boolean-Predicate syntax
URL: https://github.com/apache/spark/pull/25074#discussion_r305595789
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -1243,6 +1244,12 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
IsNotNull(e)
case SqlBaseParser.NULL =>
IsNull(e)
+ case SqlBaseParser.TRUE =>
+ invertIfNotDefined(BooleanTest(e, Some(true)))
+ case SqlBaseParser.FALSE =>
+ invertIfNotDefined(BooleanTest(e, Some(false)))
+ case SqlBaseParser.UNKNOWN =>
+ invertIfNotDefined(BooleanTest(e, None))
Review comment:
I'm still reluctant for this as I mentioned before in my previous comments.
The current PR direction is not aligned to the advice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
