dongjoon-hyun commented on a change in pull request #25213:
[SPARK-28462][SQL][TEST] Add a prefix '*' to non-nullable attribute names in
PlanTestBase.comparePlans failures
URL: https://github.com/apache/spark/pull/25213#discussion_r305634670
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/PlanTest.scala
##########
@@ -84,6 +84,13 @@ trait PlanTestBase extends PredicateHelper with SQLHelper {
self: Suite =>
}
}
+ private def rewriteNameFromAttrNullability(plan: LogicalPlan): LogicalPlan =
{
Review comment:
Since this function is used only at decoration, it's safe to have this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
