HyukjinKwon commented on a change in pull request #25215:
[SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by
and aggregate expression
URL: https://github.com/apache/spark/pull/25215#discussion_r305649132
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/PythonUDF.scala
##########
@@ -67,4 +67,12 @@ case class PythonUDF(
exprId = resultId)
override def nullable: Boolean = true
+
+ /**
+ * `resultId` can be seen as cosmetic variation in PythonUDF, as it doesn't
affect the result.
Review comment:
no biggie but maybe it's better to put this comment around
`Canonicalize.execute(this.copy(resultId = ExprId(-1))` (not as a method doc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
