HyukjinKwon commented on a change in pull request #25212:
[SPARK-28460][SQL][TEST] Port test from HIVE-11835
URL: https://github.com/apache/spark/pull/25212#discussion_r305655503
##########
File path:
sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala
##########
@@ -604,541 +604,551 @@ class HiveCompatibilitySuite extends HiveQueryFileTest
with BeforeAndAfter {
* The set of tests that are believed to be working in catalyst. Tests not
on whiteList or
* blacklist are implicitly marked as ignored.
*/
- override def whiteList: Seq[String] = Seq(
Review comment:
@wangyum, can we:
```scala
private val commonList: Seq[String] = Seq(
...
)
override def whiteList: Seq[String] = if (HiveUtils.isHive23) {
commonList ++ Seq(
"decimal_1_1"
)
} else {
commonList
}
```
to keep the history intact?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
