tgravescs commented on a change in pull request #25047:
[WIP][SPARK-27371][CORE] Support GPU-aware resources scheduling in Standalone
URL: https://github.com/apache/spark/pull/25047#discussion_r306016086
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -380,6 +384,22 @@ class SparkContext(config: SparkConf) extends Logging {
val resourcesFileOpt = conf.get(DRIVER_RESOURCES_FILE)
_resources = getOrDiscoverAllResources(_conf, SPARK_DRIVER_PREFIX,
resourcesFileOpt)
Review comment:
its unfortunate we need to call parseAllResourceRequests multiple times, but
looking it I don't see an easy way not to that doesn't hurt readability. I
would say we could separate out the log statements into a different method and
call it separate
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
