dongjoon-hyun commented on a change in pull request #25232: [SPARK-28475][CORE]
Add regex MetricFilter to GraphiteSink
URL: https://github.com/apache/spark/pull/25232#discussion_r306066248
##########
File path: core/src/main/scala/org/apache/spark/metrics/sink/GraphiteSink.scala
##########
@@ -20,9 +20,8 @@ package org.apache.spark.metrics.sink
import java.util.{Locale, Properties}
import java.util.concurrent.TimeUnit
-import com.codahale.metrics.MetricRegistry
+import com.codahale.metrics.{Metric, MetricFilter, MetricRegistry}
import com.codahale.metrics.graphite.{Graphite, GraphiteReporter, GraphiteUDP}
-
Review comment:
This empty line is one of the required Apache Spark coding styles.
```
[error]
/home/jenkins/workspace/SparkPullRequestBuilder/core/src/main/scala/org/apache/spark/metrics/sink/GraphiteSink.scala:25:0:
There should at least one a single empty line separating groups 3rdParty and
spark.
```
You can run the code style checker by the following.
```
$ dev/scalastyle
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
