HyukjinKwon commented on issue #25232: [SPARK-28475][CORE] Add regex MetricFilter to GraphiteSink URL: https://github.com/apache/spark/pull/25232#issuecomment-514015780 @nkarpov, please update this comment in the PR description under `How was this patch tested?`. Also, since there is no test, it would be better to describe, with commands, step by step from scratch. With explicit steps, we and our descendants later can detect regressions later other fixes come. Otherwise, every time we should parse your steps and come up with the proper commands. Ideally it should be copy-and-pastable to reduce human efforts since there's no test case that detects regression automatically.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
