cloud-fan commented on a change in pull request #25134: [SPARK-28366][CORE] 
Logging in driver when loading single large unsplittable file
URL: https://github.com/apache/spark/pull/25134#discussion_r306187576
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala
 ##########
 @@ -196,6 +197,8 @@ class HadoopRDD[K, V](
     newInputFormat
   }
 
+  @transient private lazy val codecFactory = new 
CompressionCodecFactory(getJobConf())
 
 Review comment:
   shall we create the codec factory inside `getPartitions`? According to the 
doc of `RDD#getPartitions`, this method will only be called once.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to