Github user hhbyyh commented on the pull request:
https://github.com/apache/spark/pull/3997#issuecomment-70109130
Just send an update. I didn't use`sqdist` due to the performance concern.
Since the original equals is actually a fail-fast comparison, yet `sqdist` will
inevitably compute through the vectors even if the first element is different.
The performance will be hard to accept for scenarios like doc2Vec over a large
vocabulary.
Current implementation is still based on the comparison for indices and
values, just with the handling of the explicit 0. I gave some tests to the
implementation and add a few ut. Any comment will be welcome!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
