dongjoon-hyun commented on a change in pull request #25238: [SPARK-28152][SQL]
Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect
URL: https://github.com/apache/spark/pull/25238#discussion_r306604135
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
##########
@@ -860,6 +860,29 @@ class JDBCSuite extends QueryTest
Some(TimestampType))
}
+ test("MsSqlServerDialect jdbc type mapping") {
Review comment:
That's exactly what I meant, @shivsood . The above comment is not about
requesting changes. It was supporting your code. Usually, reviewers leave their
comments for this other reviewers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
