HyukjinKwon commented on issue #25022: [SPARK-24695][SQL] Move 
`CalendarInterval` to org.apache.spark.sql.types package
URL: https://github.com/apache/spark/pull/25022#issuecomment-514472372
 
 
   Let's file a JIRA for each.
   
   1. SQL parser side: we need a change like this 
https://github.com/apache/spark/pull/25189/commits/e7e2f5bc2c88958fb672d133b55e8c01b7298f40#diff-9847f5cef7cf7fbc5830fbc6b779ee10R1929
   2. Python side:
     - see 
https://github.com/apache/spark/blob/master/python/pyspark/sql/types.py#L45-L94 
We need to define the interval type class and should support presumably time 
delta in Python
     - need to check if this works with Python serde. Let's say how it works 
with Python UDF. See 
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/python/EvaluatePython.scala
   3. R side:
     - R side does not have type class instances IIRC. So we wouldn't need to 
define the class
     - However, we should still fix R serde side as well. Presumably `difftime` 
instances might have to be matched with interval type in SQL sides. See 
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/api/r/SerDe.scala
 and https://github.com/apache/spark/blob/master/R/pkg/R/types.R

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to