albertusk95 commented on a change in pull request #25077: [SPARK-28301][SQL] 
fix the behavior of table name resolution with multi-catalog
URL: https://github.com/apache/spark/pull/25077#discussion_r306664050
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala
 ##########
 @@ -181,29 +181,32 @@ case class CreateViewCommand(
    * Permanent views are not allowed to reference temp objects, including temp 
function and views
    */
   private def verifyTemporaryObjectsNotExists(sparkSession: SparkSession): 
Unit = {
 
 Review comment:
   for the sake of consistency, I think it'd be better to use either 
`sparkSession` or `session` like the below methods after this one

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to