MaxGekk commented on a change in pull request #25230: [SPARK-28471][SQL] Replace `yyyy` by `uuuu` in date-timestamp patterns without era URL: https://github.com/apache/spark/pull/25230#discussion_r306863581
########## File path: sql/core/src/test/resources/sql-tests/results/pgSQL/date.sql.out ########## @@ -520,7 +520,7 @@ select make_date(-44, 3, 15) -- !query 48 schema struct<make_date(-44, 3, 15):date> -- !query 48 output -0045-03-15 +-0044-03-15 Review comment: Postgres's answer is `44 BC` for `-44` https://github.com/postgres/postgres/blob/master/src/test/regress/expected/date.out#L1454-L1457 which is wrong. It must be `45 BC` or `-44` (see https://github.com/apache/spark/pull/25210#discussion_r305609274). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
