nkarpov commented on issue #25232: [SPARK-28475][CORE] Add regex MetricFilter to GraphiteSink URL: https://github.com/apache/spark/pull/25232#issuecomment-514693595 Thanks @HeartSaVioR - I've added a better regex example in the test. And you make a good point re: whitelist/blacklist - I think it'll be clear with an example in metrics.properties template? Should we rename the config? Otherwise, @HeartSaVioR @HyukjinKwon @dongjoon-hyun, it's my first commit so please help me understand what it takes to be merged :) My only outstanding item ATM is to include an example in metrics.properties template file if we are good on naming convention.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
