HyukjinKwon commented on a change in pull request #25245:
[SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0
URL: https://github.com/apache/spark/pull/25245#discussion_r307092864
##########
File path:
mllib/src/main/scala/org/apache/spark/ml/source/image/ImageFileFormat.scala
##########
@@ -98,3 +103,163 @@ private[image] class ImageFileFormat extends FileFormat
with DataSourceRegister
}
}
}
+
+object ImageFileFormat {
Review comment:
`BinaryFileFormat` has to be private. We only don't do `private[sql]` or
`private[spark]` in execution and catalyst modules because we explicitly
mention that those modules are private as of SPARK-16813 and SPARK-16964
I don't think we should keep non-API instances as public.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
